Fix expected results for video loading from multiple origins#33342
Closed
Fix expected results for video loading from multiple origins#33342
Conversation
See whatwg/html#7655 When loading video from multiple opaque origins (by a middleman service-worker), video loading should fail rather than be alllowed and taint the canvas. That's because some of the video responses may contain metadata such as duration that would leak to the subsequent requests. See whatwg/html#2814 (comment) for further details. This change makes the test case pass in all browsers.
3 tasks
karlt
approved these changes
Apr 4, 2022
Contributor
karlt
left a comment
There was a problem hiding this comment.
Looks like this change has already been made via https://github.com/web-platform-tests/wpt/pull/33326/files#diff-1a4ae33754e5c61b26cb85ff037bfd7005cee4101a019cd87cbdece18b5754b0 but LGTM thanks.
Contributor
Author
Oh, accidental I guess but no harm done. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See whatwg/html#7655
When loading video from multiple opaque origins (by a middleman service-worker),
video loading should fail rather than be alllowed and taint the canvas.
That's because some of the video responses may contain metadata such as duration that
would leak to the subsequent requests.
See whatwg/html#2814 (comment) for further details.
This change makes the test case pass in all browsers.