Add support for perspective(none) transform function.#31158
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Oct 16, 2021
Merged
Add support for perspective(none) transform function.#31158chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Oct 7, 2021
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
e67705f to
3fb3eef
Compare
58a8af2 to
f6901ef
Compare
This adds support for the none value of the perspective() function of the transform property, and makes corresponding changes to the css-typed-om implementation. The changes to ui/gfx/geometry/ and compositor_transform_operations.cc correspond both to the interpolation changes in this patch and also some that should have been included in https://crrev.com/c/2924023 (to keep the compositor animation behavior matching the blink animation behavior). The added web-platform-tests in css/css-transforms/animation/transform-interpolation-perspective.html css/css-transforms/animation/support/transform-interpolation-reftests.js test for the need for both sets of changes to this code. The spec changes are linked from: w3c/csswg-drafts#6488 w3c/css-houdini-drafts#1051 Fixed: 1253596 Bug: 1205161 Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#932253}
f6901ef to
12638b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the none value of the perspective() function of
the transform property, and makes corresponding changes to the
css-typed-om implementation.
The changes to ui/gfx/geometry/ and compositor_transform_operations.cc
correspond both to the interpolation changes in this patch and also some
that should have been included in https://crrev.com/c/2924023 (to keep
the compositor animation behavior matching the blink animation
behavior). The added web-platform-tests in
css/css-transforms/animation/transform-interpolation-perspective.html
css/css-transforms/animation/support/transform-interpolation-reftests.js
test for the need for both sets of changes to this code.
The spec changes are linked from:
w3c/csswg-drafts#6488
w3c/css-houdini-drafts#1051
Fixed: 1253596
Bug: 1205161
Change-Id: I84f4dc509bcfccdac0dde8e42669ac0ac5e2e38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202491
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932253}