Create resource timing entries for fetch network errors#30970
Merged
Conversation
20 tasks
yoavweiss
reviewed
Sep 27, 2021
Contributor
yoavweiss
left a comment
There was a problem hiding this comment.
Thanks!! A few comments
ebf1400 to
13f67ce
Compare
Contributor
Author
Thanks! |
2 tasks
13f67ce to
c2496a3
Compare
Contributor
Author
|
Modified test to include only 5 scenarios for now:
Currently Chrome & Firefox are inconsistent around which of these create a resource timing entry. |
Contributor
Author
|
This actually catches a Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1523275 |
yoavweiss
approved these changes
Nov 19, 2021
Contributor
yoavweiss
left a comment
There was a problem hiding this comment.
LGTM % nit and suggestion for another test
Contributor
Author
|
The Firefox failures are legit, e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1523275. How does this get merged when it fails firefox nightly? |
Contributor
Author
Added a test for mixed content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial tests for whatwg/fetch#1215
Added test cases for several network error scenarios. The test cases verify that a resource timing entry is created for those resources, without the "internal" timing info (redirects, networking), as if the resource was cross-origin no-cors and lacked TAO.
The error test cases include:
These tests come in conjunction with whatwg/fetch#1311