[Gecko Bug 1312588] Part 2: Support fit-content() in style.#29272
Merged
moz-wptsync-bot merged 3 commits intomasterfrom Jun 8, 2021
Merged
[Gecko Bug 1312588] Part 2: Support fit-content() in style.#29272moz-wptsync-bot merged 3 commits intomasterfrom
moz-wptsync-bot merged 3 commits intomasterfrom
Conversation
Support fit-content for preferred size, min size, and max size. This patch only implement the style system. For layout part, we will do that in the following patches. Differential Revision: https://phabricator.services.mozilla.com/D107161 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1312588 gecko-commit: 160fb67fad9f4e36cc0d66e42e3aa3ac0fbc6d81 gecko-reviewers: emilio
…sic contribution. This implements fit-content() for basic layout support. For intrinsic contribution, we will do that in the following patches. Differential Revision: https://phabricator.services.mozilla.com/D111506 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1312588 gecko-commit: c5389bf6f5093317e713e04fcf41ec7967b944df gecko-reviewers: emilio
We simplified to just rely on the behavior of the plain argument. That is, width: fit-content(50%) behaves the same as width: 50%; in all circumstances, just clamped by min/max-content. Note: for block axis, we treat fit-content() as initial value its minimal and maximal value are identical and equal to the initial value in block axis. From: w3c/csswg-drafts#3731 (comment) Note: this patch doesn't include any update on flex and grid layout. We may have to come back to check it. Differential Revision: https://phabricator.services.mozilla.com/D113199 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1312588 gecko-commit: 41792e6152e6b5e8ad472e6cc21ce07352447bb8 gecko-reviewers: TYLin, emilio
wpt-pr-bot
approved these changes
Jun 8, 2021
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support fit-content for preferred size, min size, and max size. This
patch only implement the style system. For layout part, we will do that
in the following patches.
Differential Revision: https://phabricator.services.mozilla.com/D107161
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1312588
gecko-commit: 160fb67fad9f4e36cc0d66e42e3aa3ac0fbc6d81
gecko-reviewers: emilio