Refine crossOriginIsolated implementation for workers#25748
Refine crossOriginIsolated implementation for workers#25748stephenmcgruer merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
56ac316 to
415af5a
Compare
- Fix WindowOrWorketGlobalScope.crossOriginIsolated behavior for
workers.
- For SharedWorkers and ServiceWorkers it always return false. See
https://crbug.com/1131403 and https://crbug.com/1131404.
- Rename ExecutionContext::IsCrossOriginIsolated to
CrossOriginCapability. This is aligned with
https://html.spec.whatwg.org/C/#concept-settings-object-cross-origin-isolated-capability.
- Fix wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html.
I originally planned to do that in
#24600 but I couldn't
do that due to some flakiness.
- Add more tests for workers in
wpt/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https.html.
Bug: 1115379, 1018680, 1131403, 1131404
Change-Id: I2afcb01403f67a11fd06aefde1238aba16b68f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416428
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810130}
415af5a to
c3012dd
Compare
|
Yes, the changes here don't seem likely to cause flakiness. @annevk as an FYI/maybe he can confirm this is a known Firefox issue, and @stephenmcgruer to help force-merge. |
|
Looking at the history view on https://wpt.fyi/results/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html?label=master&label=experimental&aligned&q=html%2Finfrastructure%2Fsafe-passing-of-structured-data%2Fshared-array-buffers%2Fblob-data.https.html, this test looks very flaky on all platforms - many subtests fail every few runs, and Firefox times out (whilst passing most of the subtests!) about a third of the runs. So I'd call this preexisting yes, and am happy to admin merge :) |
|
Thank you very much! |
workers.
https://crbug.com/1131403 and https://crbug.com/1131404.
CrossOriginCapability. This is aligned with
https://html.spec.whatwg.org/C/#concept-settings-object-cross-origin-isolated-capability.
I originally planned to do that in
Add tests for 'cross-origin-isolated' permission #24600 but I couldn't
do that due to some flakiness.
wpt/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https.html.
Bug: 1115379, 1018680, 1131403, 1131404
Change-Id: I2afcb01403f67a11fd06aefde1238aba16b68f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416428
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810130}