[Azure Pipelines] run wpt_integration_{macOS,win}_{py36,py38} entirely using py3#23536
[Azure Pipelines] run wpt_integration_{macOS,win}_{py36,py38} entirely using py3#23536
Conversation
36ab650 to
fb6621b
Compare
|
I've gone over the 6 jobs in https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=47872 and while everything is passing, on macOS it looks like the system Python 2 is still being used for some steps. One can tell this from the deprecation warning in the "Install Python packages" step. @Hexcles @stephenmcgruer what is the level of support we're trying to ensure doesn't regress for Python 3 and should test in CI? |
|
I seem to have misread the results in #23536 (comment). After adding more logging I can confirm that it's the py3 versions of python itself, pip and tox being used on macOS and Windows. Going back to the earlier run I can't find what I reported, so I must have misread. |
|
@Hexcles @stephenmcgruer looks like this will actually works, so it's ready for review. |
Hexcles
left a comment
There was a problem hiding this comment.
LGTM % nit: maybe name the jobs as wpt_integration_{macOS,win}_py36
|
I'll call it |
e83172f to
81b9a5a
Compare
|
Sorry I meant if the |
|
Sure, I'd like those names better too. |
…y using py3 py2 was needed to update the manifest only, but that now works with py3. Incidentally fixes #23441, where the problem appears to have been some mixing of py2 and py3. This also renames job names from _py3 to _py36.
81b9a5a to
29efffb
Compare
py2 was needed to update the manifest only, but that now works with py3.
Incidentally fixes #23441,
where the problem appears to have been some mixing of py2 and py3.
This also renames job names from _py3 to _py36.