Initial implementation of the TestRendered event for reftests#20197
Merged
Initial implementation of the TestRendered event for reftests#20197
Conversation
Contributor
|
Would you mind adding some documentation for this feature? |
Contributor
Author
|
https://phabricator.services.mozilla.com/D52684 for the gecko changes and https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9b130cf3d577ac8feed26408f4a91d253c7ca7d for a try push containing these changes and the gecko changes. |
This is described in RFC #34. The TestRendered event is emitted for reftests with a `reftest-wait` class on the root at the point at which the screenshot would occurs if that class was not present. It provides a hook for test authors to dynamically modify the DOM after the initial layout and paint are complete.
60b4b2c to
4b2478e
Compare
Contributor
Author
I wouldn't. And indeed I have now added some. |
gsnedders
approved these changes
Nov 19, 2019
Member
gsnedders
left a comment
There was a problem hiding this comment.
(but I think I'd rather a further +1 here)
Ms2ger
approved these changes
Nov 26, 2019
Contributor
Ms2ger
left a comment
There was a problem hiding this comment.
+1 if you checked that the azure test failures are not relevant
sideshowbarker
approved these changes
Nov 26, 2019
Co-Authored-By: Michael[tm] Smith <mike@w3.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the changes detailed in web-platform-tests/rfcs#34