[Payment Request] Add Web Platform Tests for hasEnrolledInstrument().#15306
[Payment Request] Add Web Platform Tests for hasEnrolledInstrument().#15306chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
b3e1bc7 to
2d12a2d
Compare
The failing expectations are required because hasEnrolledInstrument() is not yet turned on by default in Blink. These tests pass when running Chrome with --enable-features=PaymentRequestHasEnrolledInstrument. Bug: 915907 Change-Id: I2189bfedad813e7942c7ddbd44aac78d1b895a30 Reviewed-on: https://chromium-review.googlesource.com/c/1461313 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630578}
2d12a2d to
66e5084
Compare
|
@foolip something went wrong in the process here. Seems none of the usual reviewers were assigned and this got auto merged? |
|
@marcoscaceres this was reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/1461313 and this is an automatic export of the change. Gecko has the same setup maintained by @jgraham , in fact ours was inspired by that. Is there a problem with the tests? I do expect the automatic nature of this to occasionally cause problems as the regular reviewers aren't notified, perhaps this is such a case? |
|
It’s not a big problem, but sometimes things land that are not yet in specs. Perhaps the policy should be that this be used for bug fixes and refinements, but not for features that haven’t become part of the spec yet... I guess we can also use one of the existing file extensions/postfixes... -tentative or whatever it is. |
|
(Also understand this is annoying because developing a feature with a good set of tests is obviously ideal 🤔) |
|
Yes, When you see non-standard things landing, I'd suggest pinging the authors in the issue asking them to rename. If you get no reaction or can't find their GitHub handle, ping me and I'll try to help. |
|
The problem imho is that no human was notified at all once this hit the wpt repo - I only discovered this by accident. Ideally, I’d like to be notified of any and all tests relating to payments (but without subscribing to the whole wpt repo). |
|
@marcoscaceres I've filed web-platform-tests/wpt-pr-bot#65 about that now. |
The failing expectations are required because hasEnrolledInstrument()
is not yet turned on by default in Blink. These tests pass when running
Chrome with --enable-features=PaymentRequestHasEnrolledInstrument.
Bug: 915907
Change-Id: I2189bfedad813e7942c7ddbd44aac78d1b895a30
Reviewed-on: https://chromium-review.googlesource.com/c/1461313
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630578}