Skip to content

Remove inactive reviewers#14798

Merged
gsnedders merged 9 commits intoweb-platform-tests:masterfrom
gsnedders:inactive-reviewers
Mar 14, 2019
Merged

Remove inactive reviewers#14798
gsnedders merged 9 commits intoweb-platform-tests:masterfrom
gsnedders:inactive-reviewers

Conversation

@gsnedders
Copy link
Member

@gsnedders gsnedders commented Jan 10, 2019 •
edited
Loading

This removes reviewers who have had more than three review requests in the past year but who haven't reviewed anything. Fixes #13702.

Places where this leaves us with no reviewers:

  • css/css-display/run-in (but parent has reviewers, so let's just kill that)
  • css/css-position (very few PRs; @atanassov is the current reviewer)
  • css/css-scrollbars (very few PRs; @tantek is current? maybe +@upsuper?)
  • encrypted-media (very few PRs; @ddorwin is current)
  • feature-policy (very few PRs; @clelland is current)
  • gamepad (very few PRs; @luser is current)

I believe everyone removed here was pinged in #13702 (comment), so I don't think we need to check about anyone except for the above. If the people mentioned above want to remain reviewers, please speak now.

marcoscaceres
marcoscaceres approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Payment method id.

@marcoscaceres
Copy link
Contributor

marcoscaceres commented Jan 11, 2019

gamepad (very few PRs; @luser is current)

Happy to take gamepad as reviewer. I'll add myself.

@marcoscaceres
Copy link
Contributor

marcoscaceres commented Jan 11, 2019

@bakulf might also be good for feature-policy?

@upsuper
Copy link
Member

upsuper commented Jan 13, 2019

I'm fine for adding me to css-scrollbars.

@bakulf
Copy link
Contributor

bakulf commented Jan 14, 2019

I'm fine to be added as feature-policy reviewer.

marcoscaceres
marcoscaceres reviewed Jan 14, 2019
View reviewed changes
@marcoscaceres
Copy link
Contributor

marcoscaceres commented Jan 14, 2019

Thanks @bakulf. Suggested you https://github.com/web-platform-tests/wpt/pull/14798/files#r247437966

@gsnedders
Copy link
Member Author

gsnedders commented Jan 14, 2019

OK, so that leaves css/css-position and encrypted-media without reviewers.

@astearns
Copy link
Contributor

astearns commented Jan 14, 2019

You can add me as the css-position reviewer for now.

@gsnedders
Copy link
Member Author

gsnedders commented Jan 14, 2019

For encrypted-media: @ddorwin, @jrummell-chromium? @cpearce? @jyavenard?

@gsnedders gsnedders mentioned this pull request Jan 15, 2019
Closed
@mounirlamouri
Copy link
Contributor

mounirlamouri commented Jan 15, 2019 •
edited
Loading

For encrypted-media: @ddorwin, @jrummell-chromium? @cpearce? @jyavenard?

Could you swap @ddorwin with @joeyparrish ?

alvestrand
alvestrand approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for mediacapture-main/ and webrtc/

cbiesinger
cbiesinger approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@cbiesinger cbiesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for css-flexbox

@foolip foolip mentioned this pull request Aug 19, 2019
Merged
@foolip foolip mentioned this pull request Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@alvestrand alvestrand alvestrand approved these changes

@birtles birtles birtles approved these changes

@astearns astearns astearns approved these changes

@cbiesinger cbiesinger cbiesinger approved these changes

@agouaillard agouaillard Awaiting requested review from agouaillard

@alphan102 alphan102 Awaiting requested review from alphan102

@AmeliaBR AmeliaBR Awaiting requested review from AmeliaBR

@andrey-logvinov andrey-logvinov Awaiting requested review from andrey-logvinov

@annevk annevk Awaiting requested review from annevk

@anssiko anssiko Awaiting requested review from anssiko

@aogilvie aogilvie Awaiting requested review from aogilvie

@bemjb bemjb Awaiting requested review from bemjb

@bert-github bert-github Awaiting requested review from bert-github

@bradkemper bradkemper Awaiting requested review from bradkemper

@caitp caitp Awaiting requested review from caitp

@calvaris calvaris Awaiting requested review from calvaris

@clelland clelland Awaiting requested review from clelland

Assignees

@Manishearth Manishearth

Labels

2dcontext accelerometer ambient-light assets battery-status bluetooth cookies CSS2 css-backgrounds css-color css-display css-exclusions css-flexbox css-grid css-logical css-position css-regions css-scrollbars css-shapes css-style-attr css-syntax css-text css-transforms css-ui css-writing-modes device-memory do not merge yet docs encrypted-media event-timing feature-policy gamepad generic-sensor gyroscope html-media-capture imagebitmap-renderingcontext magnetometer mediacapture-depth mediacapture-streams notifications offscreen-canvas orientation-sensor paint-timing payment-method-id pointerevents proximity referrer-policy resource-timing screen-orientation scroll-animations selectors speech-api streams subresource-integrity svg url vibration wake-lock webidl webmessaging webrtc webstorage webxr wg-css wg-das wg-fonts wg-html wg-immersive-web wg-payments wg-pointerevents wg-svg wg-webapps wg-webappsec wg-webperf wg-webplatform wg-webrtc WOFF2 xhr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.