Indent manager_group method calls to within the with scope#13778
Merged
Indent manager_group method calls to within the with scope#13778
manager_group method calls to within the with scope#13778Conversation
While variable binding `manager_group` does survive after the `with` statement, that will be after `__exit__` has been called. That still works, but there's no reason for the reader to wonder if there's a difference, whether indentation is intentional.
jgraham
approved these changes
Oct 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While variable binding
manager_groupdoes survive after thewithstatement, that will be after
__exit__has been called. That stillworks, but there's no reason for the reader to wonder if there's a
difference, whether indentation is intentional.