Conversation
43f5084 to
b401bd7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b401bd7449
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Amp-Thread-ID: https://ampcode.com/threads/T-019ca2d8-93c3-758c-b127-d32b39c04b83 Co-authored-by: Amp <amp@ampcode.com>
9aoy
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #974
Summary
In browser mode, test failure annotations in the
github-actionsreporter pointed to the HTTP-served bundle URL (e.g.http://localhost:PORT/@fs/...) instead of the original source file path. This prevented GitHub from correctly mapping errors back to source files.Root Causes
BrowserTestRunResulthad nogetSourcemapimplementation — the host controller always returnednull, so reporters could never resolve browser stack frames to source files.sourcesentries contained URL-relative paths orwebpack:///prefixes, which the Node.js reporter couldn't resolve to absolute filesystem paths.Changes
packages/browser/src/sourceMap/sourceMapLoader.ts— shared source map fetching utility (inline + external.map) with caching, used by both the browser client and the host controller.hostController.ts— implementgetBrowserSourcemap: loads source maps for browser JS bundles and resolvessourcesentries (relative paths,webpack:///prefixes) to absolute filesystem paths. PassgetSourcemapthroughBrowserTestRunResultso reporters receive real source locations. Fix browser runtimecloselifecycle so cleanup runs correctly in all exit paths.core/runTests.ts— build a unifiedgetSourcemapthat checks browser source maps first, then falls back to node bundler source maps.core/utils/error.ts— adddefaultResolveSourcePathto handle HTTP-origin frames correctly, addresolveSourcePathoption onparseErrorStacktrace, and add a post-resolution filter to drop frames that remain as HTTP URLs (unresolved browser runtime internals).e2e/browser-mode/githubActions.test.tsto assert thatgithub-actionsreporter annotations point to the correct source file and line.Related Links
Checklist