fix(browser): remove default process shim while keep env stubbing support#981
Merged
fix(browser): remove default process shim while keep env stubbing support#981
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8da6d0fc60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8da6d0f to
50d9ca3
Compare
9aoy
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the automatic injection of a
processobject shim in browser mode, eliminating global namespace pollution. Replaces the string-keyed__RSTEST_ENV__with a Symbol-based store (Symbol.for('rstest.env')) to hold environment variables, while ensuringrstest.stubEnv()continues to work seamlessly.Behavior diff:
processenv/argv/version/cwd/platform/nextTickundefinedby defaultglobalThis.__RSTEST_ENV__(string)globalThis[Symbol.for('rstest.env')]process.envaccesssource.define__RSTEST_ENV__Changes:
ensureProcessEnvwithensureRuntimeEnvusingSymbol.for('rstest.env')as the canonical storestubEnv/unstubAllEnvsto resolve env target from Symbol store first, fallback toprocess.envin Nodesource.defineto rewriteprocess.envandimport.meta.envto the Symbol storeprocessand no__RSTEST_ENV__string keyRelated Links
Checklist