Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds dependency checking functionality to ensure required packages are installed before attempting to use them in test environments. The change provides better error messages when dependencies like 'jsdom' or 'happy-dom' are missing.
- Introduces a
checkPkgInstalledutility function that validates package availability - Adds dependency checks to both jsdom and happy-dom test environment setups
- Creates a custom
RstestErrorclass for enhanced error reporting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/runtime/util.ts | Adds checkPkgInstalled function and RstestError class for dependency validation |
| packages/core/src/runtime/worker/env/jsdom.ts | Adds dependency check for 'happy-dom' package before setup |
| packages/core/src/runtime/worker/env/happyDom.ts | Adds dependency check for 'happy-dom' package before setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check dependency installed
before:
after:
Related Links
Checklist