feat: support rerun all tests via a CLI shortcut#454
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for rerunning all tests via the a CLI shortcut in watch mode. The change refactors the server lifecycle management to enable on-demand test execution while maintaining the development server.
- Restructured
createRsbuildServerto return bothgetRsbuildStatsandcloseServerfunctions separately - Added
runAllcallback to CLI shortcuts for triggering test reruns - Updated watch mode to support interactive test execution
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/core/runTests.ts | Refactored server lifecycle and added watch mode CLI shortcuts with rerun capability |
| packages/core/src/core/rsbuild.ts | Changed return type to separate stats getter from server closure |
| packages/core/src/core/cliShortcuts.ts | Added 'a' shortcut for rerunning all tests and removed redundant help message |
| await close(); | ||
| }, | ||
| }); | ||
| // TODO: no need `enter` |
There was a problem hiding this comment.
The TODO comment contains a grammatical error. It should read '// TODO: no need for enter' or '// TODO: enter not needed'.
Suggested change
| // TODO: no need `enter` | |
| // TODO: no need for `enter` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support rerun all tests via
aCLI shortcut.Related Links
Checklist