fix: should throw error when unknown environment#439
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling for unknown test environments by implementing validation that throws an error when an unrecognized environment is specified. The change ensures the system fails gracefully with a clear error message instead of silently ignoring unknown environments.
- Refactored environment handling from if-else to switch-case pattern for better maintainability
- Added explicit error throwing for unknown test environments
- Updated test utilities to support string type for custom environment testing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/dom/utils.ts | Updated type signature to allow string for testing unknown environments |
| tests/dom/handledError.test.ts | Added test case to verify error handling for unknown environments |
| packages/core/src/runtime/worker/index.ts | Implemented switch-case pattern with error throwing for unknown environments |
Comments suppressed due to low confidence (1)
packages/core/src/runtime/worker/index.ts:124
- The 'node' environment case is added but there's no corresponding test coverage for this environment type. Consider adding a test case to verify the node environment path.
case 'node':
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should throw error when unknown environment.
Related Links
Checklist