Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes mock functionality to work with async mock factories by updating the webpack runtime mock system and refactoring mock-related test files. The changes also include dependency updates across multiple package.json files.
Key changes:
- Enhanced mock runtime to support async mock factories with proper execution handling
- Refactored test files to use async mocking patterns and shared utilities
- Updated @rsbuild/core dependency from 1.4.8 to 1.4.9 across all packages
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/core/src/core/plugins/mockRuntime.ts | Core mock runtime enhancement to support async factories |
| tests/mock/tests/*.ts | Test files updated to use async mocking and shared utilities |
| tests/mock/src/*.ts | New test source files for mock functionality |
| */package.json | Dependency version updates for @rsbuild/core |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
9aoy
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adaption on runtime code and works with web-infra-dev/rspack#11050.
Related Links
Checklist