Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019d2904-6d55-715d-986c-c409712a1079 Co-authored-by: Amp <amp@ampcode.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Rsdoctor Bundle Diff Analysis
Found 12 projects in monorepo, 1 project with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 browserPath:
📦 Download Diff Report: browser Bundle Diff Generated by Rsdoctor GitHub Action |
Amp-Thread-ID: https://ampcode.com/threads/T-019d2904-6d55-715d-986c-c409712a1079 Co-authored-by: Amp <amp@ampcode.com>
9aoy
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
In browser mode, deeply nested runtime
import()chains depend on lazy compilation to avoid eager bundling and startup regressions. Keeping lazy compilation active also requires HMR runtime wiring to remain enabled.Implementation
rspackConfig.mode = 'development'for browser runtime behavior.hmrto alwaystrueincreateBrowserRsbuildDevConfig.createBrowserLazyCompilationConfig(setupFiles)instead of gating it by Rstest watch mode.User Impact
Browser mode preserves lazy loading behavior for deep async imports in both watch and non-watch runs, avoiding non-watch performance regressions.
Checklist