Skip to content

ci: merge lint into test workflow and gate e2e on both lint and ut#1105

Merged
fi3ework merged 1 commit intomainfrom
ci/chain-lint-before-test
Mar 25, 2026
Merged

ci: merge lint into test workflow and gate e2e on both lint and ut#1105
fi3ework merged 1 commit intomainfrom
ci/chain-lint-before-test

Conversation

@fi3ework
Copy link
Copy Markdown
Member

@fi3ework fi3ework commented Mar 25, 2026

Summary

Background

The Lint and Test workflows were separate, running independently in parallel. There was no dependency between them — e2e tests could start even if lint had not finished or had failed, wasting CI resources.

Implementation

  • Delete standalone lint.yml and merge lint as an independent job into test.yml.
  • lint runs in parallel with ut (no shared dependency on prepare), skipped only on schedule events.
  • e2e now requires both lint and ut to succeed before running.
  • test-gate rejects any upstream failure or cancelled result.

User Impact

E2E tests no longer run when lint or unit tests fail, saving CI minutes. Doc-only PRs still run lint as before.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Rsdoctor Bundle Diff Analysis

Found 12 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
adapter-rsbuild 2.1 KB 0
adapter-rslib 23.1 KB 0
adapter-rspack 5.9 KB 0
browser 2.0 MB 0
browser-react 3.7 KB 0
browser-ui 804.3 KB 0
coverage-istanbul 9.1 KB 0
core/browser 971.6 KB 0
core/loaders 869.0 B 0
core/main 1.5 MB 0
vscode/extension 60.2 MB 0
vscode/worker 14.4 KB 0

Generated by Rsdoctor GitHub Action

@fi3ework fi3ework requested a review from 9aoy March 25, 2026 12:32
@fi3ework fi3ework force-pushed the ci/chain-lint-before-test branch from ae944c2 to d26abb7 Compare March 25, 2026 12:58
@fi3ework fi3ework changed the title ci: chain Test workflow after Lint workflow succeeds ci: merge lint into test workflow and gate e2e on both lint and ut Mar 25, 2026
@fi3ework fi3ework force-pushed the ci/chain-lint-before-test branch from e97668a to 4bad35b Compare March 25, 2026 14:32
@fi3ework fi3ework enabled auto-merge (squash) March 25, 2026 14:42
@fi3ework fi3ework merged commit b3eb085 into main Mar 25, 2026
17 checks passed
@fi3ework fi3ework deleted the ci/chain-lint-before-test branch March 25, 2026 14:46
@9aoy 9aoy mentioned this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant