chore(lint): migrate rslint to flat config#1101
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the repository from legacy rslint.jsonc to a new flat-config rslint.config.mts, while adjusting catch clauses to match updated unused-binding lint behavior and improving local discoverability via VS Code recommendations.
Changes:
- Replaced
rslint.jsoncwith a new flat config (rslint.config.mts) using@rslint/core. - Updated several
catchclauses to remove unused bindings (or keep identifiers only when rethrowing). - Added the Rslint VS Code extension to workspace recommendations.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rslint.jsonc | Removes legacy lint configuration file. |
| rslint.config.mts | Adds new flat-config lint setup and TypeScript overrides. |
| packages/core/src/runtime/worker/loadModule.ts | Removes unused catch binding. |
| packages/core/src/runtime/runner/runner.ts | Removes unused catch binding. |
| packages/core/src/core/rsbuild.ts | Removes unused catch binding. |
| packages/browser/src/watchCliShortcuts.ts | Replaces empty catch {} with an explicit no-op block. |
| packages/browser/src/hostController.ts | Renames caught error and rethrows the same identifier. |
| e2e/test-api/fixtures/moduleNotFound.test.ts | Removes unused catch binding. |
| .vscode/extensions.json | Recommends Rslint extension for local editor setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 12 projects in monorepo, 3 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 browserPath:
📦 Download Diff Report: browser Bundle Diff 📁 core/browserPath:
📦 Download Diff Report: core/browser Bundle Diff 📁 core/mainPath:
📦 Download Diff Report: core/main Bundle Diff Generated by Rsdoctor GitHub Action |
Summary
Replace
rslint.jsoncwithrslint.config.mtsand keep the existing relaxed TypeScript lint overrides in the new flat-config shape.