Conversation
|
wait for #1086 to see the diff. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f102117960
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Rsdoctor Bundle Diff AnalysisFound 12 projects in monorepo, 2 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 core/rsdoctor-browserPath:
📦 Download Diff Report: core/rsdoctor-browser Bundle Diff 📁 core/rsdoctor-mainPath:
📦 Download Diff Report: core/rsdoctor-main Bundle Diff Generated by Rsdoctor GitHub Action |
Summary
Background
The current implementation imports
jest-diffandpretty-format(Jest versions) to format assertion errors. These packages, along with their dependencies (react-is,ansi-styles), create duplicated bundles (~220KB) since@vitest/pretty-formatis already bundled invendor-assertion.js.Implementation
jest-diffwith@vitest/utils/difffor diff generationpretty-format(Jest) with@vitest/pretty-formatfor value formattingjest-diffandpretty-formatfrom dependenciesObject.values(plugins)to avoid repeated callsUser Impact
None — internal bundle optimization that reduces package size by ~220KB.
Related Links
Closes #1085 (related PR that splits worker bundles)