fix(core): propagate color env to worker processes for correct ANSI output#1081
Merged
fix(core): propagate color env to worker processes for correct ANSI output#1081
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8a1c3db42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
Worker processes spawned by
getForceColorEnv()use piped stdio (no TTY), so color-detection libraries (picocolors, chalk, jest-diff) always conclude "no color". This causes snapshot diff output and reporter output in workers to lose all ANSI styling, even when the user's terminal supports it.Implementation
getForceColorEnv()now propagatesFORCE_COLOR=1to workers when the main process detects color support, fixing lost ANSI in diff output.NO_COLOR=1andFORCE_COLOR=0are set for maximum tool compatibility.resolveForceColorEnv(pure) +getForceColorEnv(wrapper) into a single function with optional parameters for testability without mocks.User Impact
Snapshot diff output now retains ANSI colors in terminal sessions where the parent process supports color, instead of silently stripping them in worker processes.
Checklist