test(core): use unique temp file paths in extends config tests#1080
Merged
test(core): use unique temp file paths in extends config tests#1080
Conversation
Rsbuild's loadConfig cache-busts native import() with Date.now(), which has millisecond resolution. Sequential tests reusing the same file path can collide and receive a stale cached module. Use crypto.randomUUID() to generate a unique config path per test case.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The
extends.test.tsunit tests are flaky on CI (macOS and Windows). Rsbuild'sloadConfigcache-busts nativeimport()using?t=${Date.now()}, which has millisecond resolution. Sequential tests that reuse the same temp config file path can collide when twoloadConfigcalls land in the same millisecond, causing Node.js to return the previous test's cached module.Implementation
crypto.randomUUID()instead of sharing a single fixed path.beforeEachtoafterEachsince paths are now created inside each test.User Impact
None — test-only change.
Related Links
config.globals→undefined)config.testEnvironment→'happy-dom'instead of'jsdom')Checklist