fix(browser-ui): show collected cases before first result#1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The browser sidebar only populated test cases after the first
case-resultor final file result, so running files briefly showedNo test cases reported yeteven after collection had already completed.Implementation
file-readydispatch messages in the browser UI and project the collectedTestInfo[]tree into the sidebar immediatelycaseMapprojection into a pure helper to keep the runtime path small and make the behavior easy to testUser Impact
Browser watch runs now show collected test cases in the sidebar before the first test result arrives.
Checklist
Testing
pnpm exec rstest 'packages/browser-ui/src/core/caseMap.test.ts' 'packages/browser-ui/src/core/browserRpc.test.ts' 'packages/browser-ui/src/core/channel.test.ts'pnpm --filter @rstest/browser-ui typecheck