feat: support coverage.allowExternal option#1050
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Deploying rstest with
|
| Latest commit: |
f64675c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://331f5fc8.rstest.pages.dev |
| Branch Preview URL: | https://coverage-external.rstest.pages.dev |
fi3ework
reviewed
Mar 16, 2026
fi3ework
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
coverage.allowExternaloption to control whether coverage is collected for files outside the project root directory.Current behavior: Rstest instruments all files processed during bundling, including files outside the project root (e.g., sibling workspace packages in a monorepo), resulting in noisy coverage reports.
New behavior: By default (
allowExternal: false), files outside the project root are excluded from coverage reports, aligning with Jest and Vitest conventions. Users can opt in withallowExternal: truefor monorepo cross-package coverage.allowExternalcoverage.includefalse(default)false(default)truetrueRelated Links
close #1045
Checklist