Skip to content

fix(browser): move headed reload completion out of birpc#1043

Merged
fi3ework merged 1 commit intomainfrom
fix/browser-reload-ack-timeout
Mar 11, 2026
Merged

fix(browser): move headed reload completion out of birpc#1043
fi3ework merged 1 commit intomainfrom
fix/browser-reload-ack-timeout

Conversation

@fi3ework
Copy link
Copy Markdown
Member

Summary

  • move headed reloadTestFile to an ack-style RPC so the host owns file completion tracking instead of keeping a long-lived birpc promise open for the full test run
  • disable host/container birpc transport timeouts and close pending calls on WebSocket teardown so browser lifecycle timeouts stay under the host scheduler's control
  • forward runId with headed file completion events and guard against stale completions during reruns and reconnects

Validation

  • pnpm --filter @rstest/core build
  • pnpm --filter @rstest/browser build
  • pnpm --filter @rstest/browser-ui build
  • pnpm --filter @rstest/browser typecheck
  • pnpm --filter @rstest/browser-ui typecheck
  • pnpm biome check 'packages/browser/src/hostController.ts' 'packages/browser-ui/src/hooks/useRpc.ts' 'packages/browser-ui/src/main.tsx' 'packages/browser-ui/src/types.ts'
  • node 'packages/core/bin/rstest.js' run --browser.headless false 'tests/dom.test.ts' (cwd: e2e/browser-mode/fixtures/basic)
  • node 'packages/core/bin/rstest.js' run --browser.headless false (cwd: e2e/browser-mode/fixtures/locator-api)
  • node 'packages/core/bin/rstest.js' run --browser.headless false (cwd: e2e/browser-mode/fixtures/viewport)
  • manual headed verification with a temporary 65s browser test to confirm reloadTestFile no longer fails at birpc's 60s default timeout

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@fi3ework fi3ework merged commit 8cc4af7 into main Mar 11, 2026
10 checks passed
@fi3ework fi3ework deleted the fix/browser-reload-ack-timeout branch March 11, 2026 11:48
@9aoy 9aoy mentioned this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant