fix(browser): support quitting watch mode from the terminal#1026
Merged
fix(browser): support quitting watch mode from the terminal#1026
Conversation
Add a minimal q shortcut and watch hint in browser watch mode so users can exit without killing the process. Leave broader shortcut support for a future refactor that aligns with the node-mode shortcut model.
Match the browser watch tests to the new idle-state output after the minimal q shortcut change. This keeps the e2e suite asserting the watch-ready state without depending on the removed legacy message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qshortcut for browser watch mode so users can quit from the terminalpress q to quithint after browser watch runs and reuse the watch cleanup path for terminal exitsValidation
pnpm --filter @rstest/browser typecheckpnpm rstest 'packages/browser/tests/watchCliShortcuts.test.ts'