Skip to content

perf: optimize dependencies size#437

Merged
sanyuan0704 merged 2 commits intomainfrom
feat/optimize-deps
Dec 14, 2023
Merged

perf: optimize dependencies size#437
sanyuan0704 merged 2 commits intomainfrom
feat/optimize-deps

Conversation

@sanyuan0704
Copy link
Copy Markdown
Contributor

@sanyuan0704 sanyuan0704 commented Dec 7, 2023

Summary

  1. delete tailwindcss in @rspress/core, save 11.2MB space.
  2. delete @modern-js/utils in default document scene, save 6.14MB space.
  3. add fs-extra(109 kB), chalk(42.7kB), execa(293kB) in @rspress/shared, which were provided by @modern-js/utils before.
  4. change globby to pre-compiled output in @rspress/core, size: 585 kB -> 141 kB

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 7, 2023

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 0aab950
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/657a72ebc5b0400008135aa8
😎 Deploy Preview https://deploy-preview-437--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (no change from production)
Accessibility: 79 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704 sanyuan0704 merged commit 38a2c6e into main Dec 14, 2023
@sanyuan0704 sanyuan0704 deleted the feat/optimize-deps branch December 14, 2023 03:27
@chenjiahan
Copy link
Copy Markdown
Member

@rspress/core still depend on tailwindcss, should we delete it?

@sanyuan0704
Copy link
Copy Markdown
Contributor Author

sanyuan0704 commented Dec 20, 2023

@rspress/core still depend on tailwindcss, should we delete it?

Yeah, we can move it to devDependencies #471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants