Skip to content

fix(theme): remove incorrect nested SCSS selector in LlmsViewOptions#3027

Merged
SoonIter merged 2 commits intosyt-vibe-kanban/4c18-plugin-llms-llmsfrom
copilot/sub-pr-3026
Jan 19, 2026
Merged

fix(theme): remove incorrect nested SCSS selector in LlmsViewOptions#3027
SoonIter merged 2 commits intosyt-vibe-kanban/4c18-plugin-llms-llmsfrom
copilot/sub-pr-3026

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 19, 2026

Addresses review feedback from #3026 regarding an incorrect nested selector in the Llms component SCSS.

Changes

  • Removed nested .rp-llms-view-options__trigger selector that was creating an invalid descendant selector (.rp-llms-view-options__trigger .rp-llms-view-options__trigger)
  • Retained only the &--active modifier to correctly target .rp-llms-view-options__trigger--active

Before:

.rp-llms-view-options__trigger {
  &--active,
  .rp-llms-view-options__trigger {  // Creates invalid descendant selector
    background: var(--rp-c-bg-mute);
  }
}

After:

.rp-llms-view-options__trigger {
  &--active {  // Correctly targets .rp-llms-view-options__trigger--active
    background: var(--rp-c-bg-mute);
  }
}

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on moving Llms runtime components to core/theme fix(theme): remove incorrect nested SCSS selector in LlmsViewOptions Jan 19, 2026
Copilot AI requested a review from SoonIter January 19, 2026 10:06
@SoonIter SoonIter marked this pull request as ready for review January 19, 2026 10:51
@SoonIter SoonIter merged commit 8e26ae5 into syt-vibe-kanban/4c18-plugin-llms-llms Jan 19, 2026
@SoonIter SoonIter deleted the copilot/sub-pr-3026 branch January 19, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants