fix: use layout effect for theme sync#2961
Merged
SoonIter merged 2 commits intoweb-infra-dev:mainfrom Jan 5, 2026
Merged
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the theme state management by changing from useLayoutEffect to useEffect for syncing theme changes to the DOM. The stated goals are to avoid dark mode flash and properly handle SSR hydration by utilizing window.RSPRESS_THEME.
Key Changes
- Changed theme synchronization from
useLayoutEffecttouseEffectin the theme state hook - File appears to have been renamed from
useAppearance.tstouseThemeState.ts(mentioned in description)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
previously approved these changes
Jan 5, 2026
Timeless0911
approved these changes
Jan 5, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useThemeStatehook by usinguseEffectto sync theme changes to DOMChanges
useAppearance.tstouseThemeState.tswith cleaner implementationuseEffectto sync resolved theme to DOM instead of manual syncwindow.RSPRESS_THEMEfor SSR hydrationTest plan
🤖 Generated with Claude Code