fix: use SvgWrapper in LinkCard & NavScreenMenuGroup#2381
Merged
SoonIter merged 2 commits intoweb-infra-dev:mainfrom Jul 15, 2025
Merged
fix: use SvgWrapper in LinkCard & NavScreenMenuGroup#2381SoonIter merged 2 commits intoweb-infra-dev:mainfrom
SoonIter merged 2 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SoonIter
approved these changes
Jul 15, 2025
Member
|
thanks❤ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue were
LinkCardwould fail to render when replacing theme assets (as demonstrated here: https://v2.rspress.rs/guide/advanced/custom-theme#4-custom-icon). This is because it was not usingSvgWrapperlike every other theme componentI've also noticed the same issue with
NavScreenMenuGroupand also fixed it within this PRRelated issue
n/a
Checklist