test(e2e): playwright support lazyCompilation after Rsbuild 1.4.0, remove RSPRESS_LAZY_COMPILATION=false#2319
Conversation
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fd49eef to
2cc7b99
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the workaround for playwright's incompatibility with lazy compilation, which is no longer needed after Rsbuild 1.4.0. The changes clean up e2e test configuration by removing the forced disabling of lazy compilation.
- Removes
RSPRESS_LAZY_COMPILATION=falsefrom e2e test environment variables - Simplifies the comment explaining the lazy compilation escape hatch
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/node/initRsbuild.ts | Updates comment for lazy compilation configuration, removing outdated playwright reference |
| e2e/utils/runCommands.ts | Removes environment variable that disabled lazy compilation for playwright tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff Analysis📊 Quick Summary (Click to expand)
📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
…move RSPRESS_LAZY_COMPILATION=false
6e49de7 to
be99bda
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
test(e2e): playwright support lazyCompilation after Rsbuild 1.4.0, remove RSPRESS_LAZY_COMPILATION=false
Related Issue
Checklist