Skip to content

feat: migrate all the packages to "type: module" and pure esm with publint#2084

Merged
SoonIter merged 4 commits intomainfrom
syt/esm-pure
Apr 21, 2025
Merged

feat: migrate all the packages to "type: module" and pure esm with publint#2084
SoonIter merged 4 commits intomainfrom
syt/esm-pure

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Apr 21, 2025 •
edited
Loading

Summary

feat: migrate all the packages to "type: module" and pure esm with publint

https://github.com/rspack-contrib/rsbuild-plugin-publint

all the publint passed

// rslib.config.ts
import { defineConfig } from '@rslib/core';
import { pluginPublint } from 'rsbuild-plugin-publint';

export default defineConfig({
  plugins: [pluginPublint()],
  lib: [
    {
      dts: {
        bundle: true,
      },
      format: 'esm',
      syntax: 'esnext',
    },
  ],
});

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 21, 2025 •
edited
Loading

✅ Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 91be40a
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/68062608de79c600080d1cb3
😎 Deploy Preview https://deploy-preview-2084--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 21, 2025 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 91be40a
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/68062608e6aba60008597996
😎 Deploy Preview https://deploy-preview-2084--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 74 (🔴 down 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan reviewed Apr 21, 2025
View reviewed changes
@SoonIter SoonIter merged commit 69335be into main Apr 21, 2025
12 checks passed
@SoonIter SoonIter deleted the syt/esm-pure branch April 21, 2025 11:22
@colinaaa colinaaa mentioned this pull request May 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

No one assigned

Labels

change: feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SoonIter @chenjiahan @Timeless0911