Skip to content

fix(theme): unset overflow style when sidebar destroy#1949

Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
quanquan2100:repress/fix-scroll
Mar 12, 2025
Merged

fix(theme): unset overflow style when sidebar destroy#1949
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
quanquan2100:repress/fix-scroll

Conversation

@quanquan2100
Copy link
Copy Markdown
Contributor

Summary

unset overflow style when sidebar destroy

Related Issue

close #1828

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 12, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 81559fd
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67d1392df6169e00087974b9
😎 Deploy Preview https://deploy-preview-1949--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 12, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 81559fd
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67d1392d47da740008f5b655
😎 Deploy Preview https://deploy-preview-1949--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome to Rspress community❤

@SoonIter SoonIter enabled auto-merge (squash) March 12, 2025 07:52
@SoonIter SoonIter disabled auto-merge March 12, 2025 07:52
@SoonIter SoonIter enabled auto-merge (squash) March 12, 2025 07:54
@SoonIter SoonIter merged commit dfbd4b5 into web-infra-dev:main Mar 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sidebar navigation to homepage breaks scrolling on mobile (width < 960px)

3 participants