Skip to content

feat: support size option for optimization.chunkIds config#8642

Merged
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
inottn:feat/chunkIds-size
Dec 13, 2024
Merged

feat: support size option for optimization.chunkIds config#8642
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
inottn:feat/chunkIds-size

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Dec 7, 2024

Summary

close #8605

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Dec 7, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 7, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e43b84
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6754595cd002be00085a569f
😎 Deploy Preview https://deploy-preview-8642--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inottn
Copy link
Copy Markdown
Collaborator Author

inottn commented Dec 7, 2024

There are multiple formats in this document, and I think they could be unified into one. However, I'm not sure which format would be the most appropriate.

rspack/website/docs/en/config/optimization.mdx

Lines 25 to 29 in 8646ecf

| option | description |
| --------------- | ------------------------------------------------------------------------------------------------------------------------------ |
| `natural` | Use numeric ids in order of usage. |
| `named` | Use meaningful, easy-to-debug content as id. |
| `deterministic` | Use the hashed module identifier as the id to benefit from long-term caching. By default a minimum length of 3 digits is used. |

rspack/website/docs/en/config/optimization.mdx

Lines 55 to 58 in 8646ecf

| option | description |
| ----------------- | ---------------------------------------------------------------------------------------------------------------------------------------------- |
| `'named'` | Readable ids for better debugging. |
| `'deterministic'` | Short numeric ids which will not be changing between compilation. Good for long term caching. By default a minimum length of 3 digits is used. |

rspack/website/docs/en/config/optimization.mdx

Lines 371 to 376 in 8646ecf

| option | description |
| --------------- | ---------------------------------------------------------------------------------------------------------------------------------- |
| 'named' | Use meaningful, easy-to-debug content as id. This option is enabled by default in development mode |
| 'deterministic' | Use the hashed module identifier as the id to benefit from long-term caching. This option is enabled by default in production mode |
| true | Same as 'deterministic' |
| false | Keep original name. Good for readability and debugging. |

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Dec 13, 2024

@LingyuCoder @ahabhgk cc~

ahabhgk
ahabhgk approved these changes Dec 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahabhgk
Copy link
Copy Markdown
Contributor

ahabhgk commented Dec 13, 2024

'deterministic'
'named'
true
false

I prefer this format

@ahabhgk ahabhgk merged commit 52a3e42 into web-infra-dev:main Dec 13, 2024
@inottn inottn deleted the feat/chunkIds-size branch December 13, 2024 07:09
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Dec 13, 2024

I think most of these differences come from translation tools, their original intentions are similar. You can choose the more detailed version.

@inottn
Copy link
Copy Markdown
Collaborator Author

inottn commented Dec 13, 2024

I think most of these differences come from translation tools, their original intentions are similar. You can choose the more detailed version.

I wasn't clear enough in my expression. What I actually meant was the format of this area. 😄

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Configuration optimization.chunkIds support "size"

3 participants

@inottn @chenjiahan @ahabhgk