Skip to content

fix: importModule should have err #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSerFeng merged 2 commits into from
Dec 3, 2024
Merged

fix: importModule should have err #8590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdecea6
fix: importModule should have err
JSerFeng Dec 2, 2024
541a993
fix: importModule should have err
JSerFeng Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/rspack_binding_values/src/compilation/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@ impl JsCompilation {
original_module.map(ModuleIdentifier::from),
)
.await;

let js_result = JsExecuteModuleResult {
cacheable: res.cacheable,
file_dependencies: res
Expand Down
3 changes: 3 additions & 0 deletions ...test-tools/tests/diagnosticsCases/module-build-failed/loader-import-syntax-error/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
it("should compile", (done) => {
done()
});
11 changes: 11 additions & 0 deletions ...est-tools/tests/diagnosticsCases/module-build-failed/loader-import-syntax-error/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/** @type {import("../../../../dist").PitchLoaderDefinitionFunction} */
module.exports = async function () {
try {
const result = await this.importModule("./syntax-error.js");

// here should be unreachable
expect(result).toBe(Symbol('unreachable'));
} catch (e) {
expect(e).toBeDefined()
}
};
13 changes: 13 additions & 0 deletions ...ls/tests/diagnosticsCases/module-build-failed/loader-import-syntax-error/rspack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/** @type {import("@rspack/core").Configuration} */
module.exports = {
entry: "./index.js",
module: {
rules: [
{
test: /index\.js/,
loader: "./loader",
options: {}
}
]
},
};
12 changes: 12 additions & 0 deletions ...est-tools/tests/diagnosticsCases/module-build-failed/loader-import-syntax-error/stats.err
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
ERROR in ./index.js
× Module build failed:
╰─▶ × Final loader(<PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-import-syntax-error/loader.js??ruleSet[1].rules[0].use[0]) didn't return a Buffer or String

ERROR in × Module parse failed:
╰─▶ × JavaScript parsing error: Unexpected eof
╭────
1 │ console.log(
╰────

help:
You may need an appropriate loader to handle this file type.
1 change: 1 addition & 0 deletions ...ols/tests/diagnosticsCases/module-build-failed/loader-import-syntax-error/syntax-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log(
1 change: 1 addition & 0 deletions packages/rspack/src/builtin-plugin/css-extract/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const pitch: LoaderDefinition["pitch"] = function (request, _, data) {
const callback = this.async();
const filepath = this.resourcePath;
const parseMeta = this.__internal__parseMeta;
this.addDependency(filepath);

let { publicPath } = this._compilation!.outputOptions;

Expand Down
2 changes: 1 addition & 1 deletion packages/rspack/src/loader-runner/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ export async function runLoaders(
}

if (res.error) {
reject(new Error(err));
reject(new Error(res.error));
} else {
resolve(
compiler.__internal__getModuleExecutionResult(res.id)
Expand Down