fix: the attribute values of HTML tags should not be converted to lowercase#8443
Merged
LingyuCoder merged 1 commit intoweb-infra-dev:mainfrom Nov 18, 2024
Merged
fix: the attribute values of HTML tags should not be converted to lowercase#8443LingyuCoder merged 1 commit intoweb-infra-dev:mainfrom
LingyuCoder merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
LingyuCoder
reviewed
Nov 16, 2024
packages/rspack-test-tools/tests/configCases/builtins/html-issue-8410/index.js
Outdated
Show resolved
Hide resolved
afb21a2 to
100db49
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #8410
In fact, attr_name should not be converted to lowercase either, as this is the job of the minifier. However, it seems that swc_html_minifier currently does not support the caseSensitive configuration.
Checklist