Skip to content

fix(core): remove hang risk caused by coop budget in tokio#8434

Merged
hardfist merged 2 commits intomainfrom
yj/remove-hang-risk
Nov 14, 2024
Merged

fix(core): remove hang risk caused by coop budget in tokio#8434
hardfist merged 2 commits intomainfrom
yj/remove-hang-risk

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Nov 14, 2024 •
edited
Loading

Summary

rspack may have hang risk when contains too much task in join_all and block_on, and the automatic cooperative task yielding is useless in rspack scenario(we don't care task latency), it also may bring litter performance benefits(cause no need to do automatically yield)
some users report rspack may block infinitely and I'm not sure related to it.

Reference

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 14, 2024
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 14, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 26ca5b5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6735925332b960000860509f

@hardfist
Copy link
Copy Markdown
Contributor Author

hardfist commented Nov 14, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 14, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-11-14 710908b) Current Change
10000_big_production-mode + exec 44.6 s ± 902 ms 44.3 s ± 707 ms -0.59 %
10000_development-mode + exec 1.79 s ± 26 ms 1.81 s ± 25 ms +1.13 %
10000_development-mode_hmr + exec 645 ms ± 14 ms 640 ms ± 7.4 ms -0.73 %
10000_production-mode + exec 2.43 s ± 31 ms 2.41 s ± 33 ms -0.59 %
arco-pro_development-mode + exec 1.78 s ± 54 ms 1.76 s ± 62 ms -1.18 %
arco-pro_development-mode_hmr + exec 430 ms ± 1.1 ms 431 ms ± 1.8 ms +0.32 %
arco-pro_production-mode + exec 3.17 s ± 33 ms 3.18 s ± 70 ms +0.50 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.22 s ± 87 ms 3.23 s ± 80 ms +0.17 %
threejs_development-mode_10x + exec 1.58 s ± 9.6 ms 1.58 s ± 14 ms +0.14 %
threejs_development-mode_10x_hmr + exec 780 ms ± 13 ms 773 ms ± 12 ms -0.86 %
threejs_production-mode_10x + exec 4.97 s ± 32 ms 4.97 s ± 37 ms +0.12 %

LingyuCoder
LingyuCoder previously approved these changes Nov 14, 2024
View reviewed changes
@hardfist hardfist merged commit e106158 into main Nov 14, 2024
@hardfist hardfist deleted the yj/remove-hang-risk branch November 14, 2024 06:31
@h-a-n-a h-a-n-a mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder left review comments

Assignees

@hardfist hardfist

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardfist @rspack-bot @LingyuCoder