Skip to content

chore(rspack-cli): add strip-ansi in dev deps#8432

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
stormslowly:chore/rspack_cli_test_failed
Nov 14, 2024
Merged

chore(rspack-cli): add strip-ansi in dev deps#8432
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
stormslowly:chore/rspack_cli_test_failed

Conversation

@stormslowly
Copy link
Copy Markdown
Contributor

Summary

After cloning project && pnpm install, then run x ready, rspack-cli's tests failed due to strip-ansi can't be resolved.

just add it in the dev deps.

Checklist

  • Tests updated not required.
  • Documentation updated not required.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 14, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9cdf1c9
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/673550ad7f29d600082ad607

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) November 14, 2024 03:45
@chenjiahan chenjiahan merged commit 5dd500e into web-infra-dev:main Nov 14, 2024
@h-a-n-a h-a-n-a mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants