fix: output should be consistent when using splitChunks#8425
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SyMind
approved these changes
Nov 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using maxSize of splitChunks, we will split chunk that size exceeds maxSize into multiple chunks, we split modules inside original chunk, however modules' order matters, for example we may split A, B, C into AB and C, the next time we see B C A, we split them into BC and A, that's because the iterator of modules comes from HashMap which has no guarantee of iterate order, so we need to sort modules before splitting
Test case comes from https://github.com/bigbossx/split-chunk-bug by @bigbossx
Checklist