Skip to content

fix: correct favicon path when output.publicPath is set to auto#8415

Merged
LingyuCoder merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/html-favicon
Nov 16, 2024
Merged

fix: correct favicon path when output.publicPath is set to auto#8415
LingyuCoder merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/html-favicon

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Nov 12, 2024

Summary

fix #8412

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 12, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 12, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 30f57ff
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6733707e1c03490008e7bffc

Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@LingyuCoder LingyuCoder merged commit 1ca6b68 into web-infra-dev:main Nov 16, 2024
@inottn inottn deleted the fix/html-favicon branch November 16, 2024 16:08
@h-a-n-a h-a-n-a mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Favicon setting in html plugin does not work correctly when output.publicPath: "auto"

2 participants