refactor: rspack_fs use Utf8Path and FileMetadata#8366
Merged
jerrykingxyz merged 1 commit intomainfrom Nov 8, 2024
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
@jerrykingxyz can you help explain why change Path to Utf8Path in Filesystem trait here? |
1fbeaf7 to
b3ffc46
Compare
Utf8Path and FileMetadata
h-a-n-a
approved these changes
Nov 8, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update
ReadableFileSystemtrait to useUtf8PathandUtf8PathBufIn rspack we use
Utf8PathandUtf8PathBufinstead ofPathandPathBuf. more info see refactor: drop support for non-UTF8 paths #7570define
FileMetadatato replaceMetadatato make Async and Sync trait return same structChecklist