Skip to content

fix: temporarily use lightingcss_rs to fix CSS property order#8182

Merged
GiveMe-A-Name merged 1 commit intomainfrom
fix/ligthingcss-size-order
Oct 22, 2024
Merged

fix: temporarily use lightingcss_rs to fix CSS property order#8182
GiveMe-A-Name merged 1 commit intomainfrom
fix/ligthingcss-size-order

Conversation

@GiveMe-A-Name
Copy link
Copy Markdown
Member

@GiveMe-A-Name GiveMe-A-Name commented Oct 22, 2024

Summary

Lightincss have a bug about minimizing CSS may shuffle the CSS property order.

The css code:

.foo { 
   height: auto; 
   height: calc(100vh - var(--header-height, 0rem)); 
}

After lightningcss minify, css code would like this

.foo { 
   height: calc(100vh - var(--header-height, 0rem)); 
   height: auto; 
}

care the lightingcss publish cycle. we publish a new crate named lightingcss_rs;

So we update lightingcss to lightingcss_rs for fix this issues #7921

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@GiveMe-A-Name
chore: update lightingcss to lightingcss_rs
2f9bd2d 
- lightincss_rs is fork from ligthingcss, that fix the size order after
minify
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2f9bd2d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6717156c6797430008505a75

@GiveMe-A-Name GiveMe-A-Name mentioned this pull request Oct 22, 2024
Closed
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Oct 22, 2024 •
edited
Loading

Where is the source code of lightingcss_rs? Is there a branch or fork of lightningcss?

@GiveMe-A-Name
Copy link
Copy Markdown
Member Author

GiveMe-A-Name commented Oct 22, 2024

Where is the source code of lightingcss_rs? Is there a branch or fork of lightningcss?

From this branch https://github.com/GiveMe-A-Name/lightningcss/tree/fix/size-prop-order.

This is diff from lightningcss main branch between and this branch parcel-bundler/lightningcss#838

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Oct 22, 2024

I see, we should explain that this is a temporary workaround and we will switch back to the official version when lightningcss fixes the issue and releases it.

@chenjiahan chenjiahan changed the title chore: update lightingcss to lightingcss_rs fix: temporarily use lightingcss_rs to fix CSS property order Oct 22, 2024
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 22, 2024
@GiveMe-A-Name GiveMe-A-Name merged commit 71b4e5d into main Oct 22, 2024
@GiveMe-A-Name GiveMe-A-Name deleted the fix/ligthingcss-size-order branch October 22, 2024 06:26
@chenjiahan chenjiahan mentioned this pull request Nov 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@JSerFeng JSerFeng Awaiting requested review from JSerFeng JSerFeng is a code owner

Assignees

@GiveMe-A-Name GiveMe-A-Name

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GiveMe-A-Name @chenjiahan