Skip to content

fix: should use chunk in path data of compilation.getPath#8032

Merged
LingyuCoder merged 3 commits intomainfrom
fix/compilation-get-path-chunk
Oct 9, 2024
Merged

fix: should use chunk in path data of compilation.getPath#8032
LingyuCoder merged 3 commits intomainfrom
fix/compilation-get-path-chunk

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Sep 30, 2024

Summary

fix #7960

Not support chunk contenthash yet, need to add contentHashType field, perhaps should support it in the future

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 30, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 30, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2b1c584
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67061e1a7b93f000085504e0

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 30, 2024
@LingyuCoder LingyuCoder marked this pull request as draft September 30, 2024 09:23
@LingyuCoder LingyuCoder force-pushed the fix/compilation-get-path-chunk branch from 8ab9801 to dedca20 Compare September 30, 2024 10:08
@LingyuCoder LingyuCoder changed the title fix: should use chunk in path data of compilation.getPath fix: should use existing chunk in path data of compilation.getPath Sep 30, 2024
@LingyuCoder LingyuCoder force-pushed the fix/compilation-get-path-chunk branch from 5faaa19 to 5d962a8 Compare October 8, 2024 10:48
@LingyuCoder LingyuCoder changed the title fix: should use existing chunk in path data of compilation.getPath fix: should use chunk in path data of compilation.getPath Oct 9, 2024
@LingyuCoder LingyuCoder requested a review from SyMind October 9, 2024 06:42
@LingyuCoder LingyuCoder marked this pull request as ready for review October 9, 2024 06:42
@LingyuCoder LingyuCoder enabled auto-merge (squash) October 9, 2024 06:58
@LingyuCoder LingyuCoder merged commit f8f850e into main Oct 9, 2024
@LingyuCoder LingyuCoder deleted the fix/compilation-get-path-chunk branch October 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: license-webpack-plugin will not replace "[name]" in "outputFilename"

2 participants