Skip to content

fix: correctly display the progress bar when it reaches 100%#7989

Merged
LingyuCoder merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/7988
Sep 26, 2024
Merged

fix: correctly display the progress bar when it reaches 100%#7989
LingyuCoder merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/7988

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Sep 25, 2024

Summary

fix #7988

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 25, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 25, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 2da56d5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f455749d8b4400088e8e54

@nuintun
Copy link
Copy Markdown

nuintun commented Sep 26, 2024

@inottn

There are some issues with the progress values

0.09 -> 0.01 -> 0.69

image

and the progress at different stages of sealing is the same (0.7), see webpack progress screenshot

image

@inottn
Copy link
Copy Markdown
Collaborator Author

inottn commented Sep 26, 2024

@inottn

There are some issues with the progress values

Thanks for your feedback, I will fix it later.

Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@LingyuCoder LingyuCoder merged commit 8acf5be into web-infra-dev:main Sep 26, 2024
@inottn inottn deleted the fix/7988 branch September 26, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The progress bar did not reach 100% after the compilation was completed

3 participants