Skip to content

feat: support "loose-unrecognized-keys" for config validation#7705

Merged
chenjiahan merged 9 commits intomainfrom
feat-support-unrecognized-keys
Aug 27, 2024
Merged

feat: support "loose-unrecognized-keys" for config validation#7705
chenjiahan merged 9 commits intomainfrom
feat-support-unrecognized-keys

Conversation

@h-a-n-a
Copy link
Copy Markdown
Contributor

@h-a-n-a h-a-n-a commented Aug 27, 2024 •
edited
Loading

Summary

Support "loose-unrecognized-keys" for RSPACK_CONFIG_VALIDATE.

  • "loose-silent": ignore every config validation errors
  • "loose": warn every config validation errors
  • "loose-unrecognized-keys": only warn unrecognized keys(this is for compatibility for webpack configs) and treat other errors as "strict" mode does.
  • "strict": return every config validation errors

There's no breaking changes in this PR: "loose" is the default value of RSPACK_CONFIG_VALIDATE in rspack-cli. "strict" is the default value for calling compiler programmatically.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@h-a-n-a h-a-n-a added the release: breaking change release: breaking change related release(mr only) label Aug 27, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 27, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Aug 27, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 80537de
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66cdc17299948500082082bd

@h-a-n-a h-a-n-a removed the release: breaking change release: breaking change related release(mr only) label Aug 27, 2024
chenjiahan
chenjiahan previously approved these changes Aug 27, 2024
View reviewed changes
chenjiahan
chenjiahan reviewed Aug 27, 2024
View reviewed changes
@h-a-n-a h-a-n-a requested a review from chenjiahan August 27, 2024 11:54
@chenjiahan chenjiahan merged commit d266313 into main Aug 27, 2024
@chenjiahan chenjiahan deleted the feat-support-unrecognized-keys branch August 27, 2024 12:21
This was referenced Aug 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-a-n-a @chenjiahan