Skip to content

feat: port "module-import" external type#7479

Merged
fi3ework merged 1 commit intoweb-infra-dev:mainfrom
fi3ework:module-import
Aug 7, 2024
Merged

feat: port "module-import" external type#7479
fi3ework merged 1 commit intoweb-infra-dev:mainfrom
fi3ework:module-import

Conversation

@fi3ework
Copy link
Copy Markdown
Member

@fi3ework fi3ework commented Aug 7, 2024

Summary

Port webpack/webpack#18620.

Changes overview:

  1. add module-import external type.
  2. change external type to module-import by default when output.module is enabled (not all cases could be ported as we lack other feature supports at preset).
  3. sync up documentation.

Potentially problematic changes:

Added rspack_plugin_javascript to the dep of rspack_plugin_externals to use some variables, is it ok to do so?

rspack_plugin_javascript = { path = "../rspack_plugin_javascript" }

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Aug 7, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 7, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bd92cbd
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b3130f7596a70008e3d409
😎 Deploy Preview https://deploy-preview-7479--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 7, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6f1bf66
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b319d4e4aa6c000737d23c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants