feat(node-stuff): implement node-module shim#7465
Merged
fi3ework merged 1 commit intoweb-infra-dev:mainfrom Aug 7, 2024
Merged
feat(node-stuff): implement node-module shim#7465fi3ework merged 1 commit intoweb-infra-dev:mainfrom
node-module shim#7465fi3ework merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
14a83ea to
4288bda
Compare
ahabhgk
previously approved these changes
Aug 7, 2024
ahabhgk
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port https://webpack.js.org/configuration/node/#root:~:text=%27node%2Dmodule%27%3A%20Replace%20__filename%20in%20CommonJS%20modules%20to%20fileURLToPath(import.meta.url)%20when%20output.module%20is%20enabled.
Rename the former
ExternalModuleenum toModuleExternalinInitFragmentKey(https://github.com/webpack/webpack/blob/main/lib/ExternalModule.js#L225), and add newExternalModuletype (https://github.com/webpack/webpack/blob/main/lib/dependencies/ExternalModuleInitFragment.js#L20) to comply with webpack's naming.Resolve web-infra-dev/rslib#32.
Checklist