You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove buildInfo.assetFilenames because it is immutable after module making parse.
Add compilation.module_assets to store the mapping from module identifier to emitted assets.
Using loaderContext.emitFile will add a mapping here and add the asset to chunks which are related to module.
Using loaderContext.emitFile in loaderContext.importModule, the module asset from emitFile will on the main compilation but the chunk asset will on the execute module compilation. So we need to collect all module assets of execute module compilation and add them to the executing entry module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: bug fixrelease: bug related release(mr only)teamThe issue/pr is created by the member of Rspack.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close #4923
Collect auxiliary assets from module
buildInfo.assetFilenamesbecause it is immutable after module making parse.compilation.module_assetsto store the mapping from module identifier to emitted assets.loaderContext.emitFilewill add a mapping here and add the asset to chunks which are related to module.loaderContext.emitFileinloaderContext.importModule, the module asset fromemitFilewill on the main compilation but the chunk asset will on the execute module compilation. So we need to collect all module assets of execute module compilation and add them to the executing entry module.Checklist