Skip to content

docs: polish up output config#7167

Merged
chenjiahan merged 17 commits intoweb-infra-dev:mainfrom
fi3ework:polish-up-output
Jul 15, 2024
Merged

docs: polish up output config#7167
chenjiahan merged 17 commits intoweb-infra-dev:mainfrom
fi3ework:polish-up-output

Conversation

@fi3ework
Copy link
Copy Markdown
Member

Summary

Polish up output documentation. The main target is to align with webpack's document if the abilities are aligned. Put legacy / tend to be deprecated fields to the end of the page and only provide a link to its substitute.

Configuration not aligned with webpack

  • do not support output.charset
  • do not support output.chunkLoadTimeout
  • output.clean only supports boolean
  • do not support output.compareBeforeEmit
  • do not support output.cssHeadDataCompression
  • do not support output.ignoreBrowserWarnings
  • do not support output.importMetaName
  • do not support output.sourcePrefix
  • do not support output.trustedTypes.onPolicyCreationFailure
  • output.publicPath only supports string
  • do not support strictModuleExceptionHandling (deprecated)
  • output.assetModuleFilename only supports string

I wonder, do we need to create a centralized issue to collect all config that misaligned with webpack and track in the future.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: document release: document related release(mr only) label Jul 15, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 15, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e9a558
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66952dca87c2ae000860d7b1
😎 Deploy Preview https://deploy-preview-7167--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework requested a review from chenjiahan July 15, 2024 12:03
@chenjiahan
Copy link
Copy Markdown
Member

do we need to create a centralized issue to collect all config that misaligned with webpack and track in the future.

Agreed, it would be helpful if we could maintain such an issue to track the alignment progress.

fi3ework and others added 16 commits July 15, 2024 21:41
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chenjiahan chenjiahan merged commit 338d52a into web-infra-dev:main Jul 15, 2024
@fi3ework
Copy link
Copy Markdown
Member Author

@chenjiahan Thanks for your careful review. I'll trying to do better next time. 😆

@fi3ework
Copy link
Copy Markdown
Member Author

do we need to create a centralized issue to collect all config that misaligned with webpack and track in the future.

Agreed, it would be helpful if we could maintain such an issue to track the alignment progress.

I'll create one later.

@fi3ework fi3ework deleted the polish-up-output branch July 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: document release: document related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants