Skip to content

fix: fix type of CssExtractRspackPluginOptions.{filename,chunkFilename}#6882

Merged
xc2 merged 1 commit intoweb-infra-dev:mainfrom
xc2:fix-css-extract-filename-type
Jun 24, 2024
Merged

fix: fix type of CssExtractRspackPluginOptions.{filename,chunkFilename}#6882
xc2 merged 1 commit intoweb-infra-dev:mainfrom
xc2:fix-css-extract-filename-type

Conversation

@xc2
Copy link
Copy Markdown
Collaborator

@xc2 xc2 commented Jun 21, 2024

Summary

closes #6215

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jun 21, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 21, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 784a045
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66793d1fc782200008d555f9
😎 Deploy Preview https://deploy-preview-6882--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xc2 xc2 requested a review from JSerFeng June 21, 2024 06:30
@chenjiahan
Copy link
Copy Markdown
Member

Great, Rsbuild's output.filename.css can be a function after this fix 😄

web-infra-dev/rsbuild#2526

@xc2 xc2 force-pushed the fix-css-extract-filename-type branch from f71220b to 784a045 Compare June 24, 2024 09:32
@xc2 xc2 merged commit b531260 into web-infra-dev:main Jun 24, 2024
@xc2 xc2 deleted the fix-css-extract-filename-type branch June 24, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support function type for CssExtractRspackPlugin.filename and CssExtractRspackPlugin.chunkFilename

3 participants